crypto/secret: fix inconsequential errors.

qemu with hax to log dma reads & writes jcs.org/2018/11/12/vfio

Change condition from QCRYPTO_SECRET_FORMAT_RAW
to QCRYPTO_SECRET_FORMAT_BASE64 in if-operator, because
this is potential error if you add another format value.

Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Signed-off-by: Alexey Krasikov <alex-krasikov@yandex-team.ru>
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>

authored by

Alexey Krasikov and committed by

Daniel P. Berrangé 5 years ago 861c50bf 569644f7

+1 -1

1 changed file

expand all

crypto

secret.c

+1 -1

crypto/secret.c

··· 204 204 input = output; 205 205 inputlen = outputlen; 206 206 } else { 207 - if (secret->format != QCRYPTO_SECRET_FORMAT_RAW) { 207 + if (secret->format == QCRYPTO_SECRET_FORMAT_BASE64) { 208 208 qcrypto_secret_decode(input, inputlen, 209 209 &output, &outputlen, &local_err); 210 210 g_free(input);