jcs.org
qemu with hax to log dma reads & writes
jcs.org/2018/11/12/vfio
memory: Simplify memory_region_init_rom_nomigrate() to ease review
memory_region_init_rom_nomigrate() has the same content than
memory_region_init_ram_shared_nomigrate(), with setting the
readonly mode. The code is easier to review as creating a
readonly ram/shared/nomigrate region.
Reviewed-by: Alistair Francis <alistair.francis@wdc.com>
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
authored by
Philippe Mathieu-Daudé
and committed by
Paolo Bonzini
83696c8f
39fa93c4
+1
-12
+1
-12
memory.c
+1
-12
memory.c
···
1660
1660
uint64_t size,
1661
1661
Error **errp)
1662
1662
{
1663
-
Error *err = NULL;
1664
-
memory_region_init(mr, owner, name, size);
1665
-
mr->ram = true;
1663
+
memory_region_init_ram_shared_nomigrate(mr, owner, name, size, false, errp);
1666
1664
mr->readonly = true;
1667
-
mr->terminates = true;
1668
-
mr->destructor = memory_region_destructor_ram;
1669
-
mr->ram_block = qemu_ram_alloc(size, false, mr, &err);
1670
-
mr->dirty_log_mask = tcg_enabled() ? (1 << DIRTY_MEMORY_CODE) : 0;
1671
-
if (err) {
1672
-
mr->size = int128_zero();
1673
-
object_unparent(OBJECT(mr));
1674
-
error_propagate(errp, err);
1675
-
}
1676
1665
}
1677
1666
1678
1667
void memory_region_init_rom_device_nomigrate(MemoryRegion *mr,