jcs.org
qemu with hax to log dma reads & writes
jcs.org/2018/11/12/vfio
iotests: test manual job dismissal
Signed-off-by: John Snow <jsnow@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
authored by
John Snow
and committed by
Kevin Wolf
6d8be967
b40dacdc
+189
-2
+187
tests/qemu-iotests/056
+187
tests/qemu-iotests/056
···
29
29
test_img = os.path.join(iotests.test_dir, 'test.img')
30
30
target_img = os.path.join(iotests.test_dir, 'target.img')
31
31
32
+
def img_create(img, fmt=iotests.imgfmt, size='64M', **kwargs):
33
+
fullname = os.path.join(iotests.test_dir, '%s.%s' % (img, fmt))
34
+
optargs = []
35
+
for k,v in kwargs.iteritems():
36
+
optargs = optargs + ['-o', '%s=%s' % (k,v)]
37
+
args = ['create', '-f', fmt] + optargs + [fullname, size]
38
+
iotests.qemu_img(*args)
39
+
return fullname
40
+
41
+
def try_remove(img):
42
+
try:
43
+
os.remove(img)
44
+
except OSError:
45
+
pass
46
+
47
+
def io_write_patterns(img, patterns):
48
+
for pattern in patterns:
49
+
iotests.qemu_io('-c', 'write -P%s %s %s' % pattern, img)
50
+
51
+
32
52
class TestSyncModesNoneAndTop(iotests.QMPTestCase):
33
53
image_len = 64 * 1024 * 1024 # MB
34
54
···
107
127
self.assert_qmp(result, 'return', {})
108
128
event = self.cancel_and_wait()
109
129
self.assert_qmp(event, 'data/type', 'backup')
130
+
131
+
class BackupTest(iotests.QMPTestCase):
132
+
def setUp(self):
133
+
self.vm = iotests.VM()
134
+
self.test_img = img_create('test')
135
+
self.dest_img = img_create('dest')
136
+
self.vm.add_drive(self.test_img)
137
+
self.vm.launch()
138
+
139
+
def tearDown(self):
140
+
self.vm.shutdown()
141
+
try_remove(self.test_img)
142
+
try_remove(self.dest_img)
143
+
144
+
def hmp_io_writes(self, drive, patterns):
145
+
for pattern in patterns:
146
+
self.vm.hmp_qemu_io(drive, 'write -P%s %s %s' % pattern)
147
+
self.vm.hmp_qemu_io(drive, 'flush')
148
+
149
+
def qmp_backup_and_wait(self, cmd='drive-backup', serror=None,
150
+
aerror=None, **kwargs):
151
+
if not self.qmp_backup(cmd, serror, **kwargs):
152
+
return False
153
+
return self.qmp_backup_wait(kwargs['device'], aerror)
154
+
155
+
def qmp_backup(self, cmd='drive-backup',
156
+
error=None, **kwargs):
157
+
self.assertTrue('device' in kwargs)
158
+
res = self.vm.qmp(cmd, **kwargs)
159
+
if error:
160
+
self.assert_qmp(res, 'error/desc', error)
161
+
return False
162
+
self.assert_qmp(res, 'return', {})
163
+
return True
164
+
165
+
def qmp_backup_wait(self, device, error=None):
166
+
event = self.vm.event_wait(name="BLOCK_JOB_COMPLETED",
167
+
match={'data': {'device': device}})
168
+
self.assertNotEqual(event, None)
169
+
try:
170
+
failure = self.dictpath(event, 'data/error')
171
+
except AssertionError:
172
+
# Backup succeeded.
173
+
self.assert_qmp(event, 'data/offset', event['data']['len'])
174
+
return True
175
+
else:
176
+
# Failure.
177
+
self.assert_qmp(event, 'data/error', qerror)
178
+
return False
179
+
180
+
def test_dismiss_false(self):
181
+
res = self.vm.qmp('query-block-jobs')
182
+
self.assert_qmp(res, 'return', [])
183
+
self.qmp_backup_and_wait(device='drive0', format=iotests.imgfmt,
184
+
sync='full', target=self.dest_img,
185
+
auto_dismiss=True)
186
+
res = self.vm.qmp('query-block-jobs')
187
+
self.assert_qmp(res, 'return', [])
188
+
189
+
def test_dismiss_true(self):
190
+
res = self.vm.qmp('query-block-jobs')
191
+
self.assert_qmp(res, 'return', [])
192
+
self.qmp_backup_and_wait(device='drive0', format=iotests.imgfmt,
193
+
sync='full', target=self.dest_img,
194
+
auto_dismiss=False)
195
+
res = self.vm.qmp('query-block-jobs')
196
+
self.assert_qmp(res, 'return[0]/status', 'concluded')
197
+
res = self.vm.qmp('block-job-dismiss', id='drive0')
198
+
self.assert_qmp(res, 'return', {})
199
+
res = self.vm.qmp('query-block-jobs')
200
+
self.assert_qmp(res, 'return', [])
201
+
202
+
def test_dismiss_bad_id(self):
203
+
res = self.vm.qmp('query-block-jobs')
204
+
self.assert_qmp(res, 'return', [])
205
+
res = self.vm.qmp('block-job-dismiss', id='foobar')
206
+
self.assert_qmp(res, 'error/class', 'DeviceNotActive')
207
+
208
+
def test_dismiss_collision(self):
209
+
res = self.vm.qmp('query-block-jobs')
210
+
self.assert_qmp(res, 'return', [])
211
+
self.qmp_backup_and_wait(device='drive0', format=iotests.imgfmt,
212
+
sync='full', target=self.dest_img,
213
+
auto_dismiss=False)
214
+
res = self.vm.qmp('query-block-jobs')
215
+
self.assert_qmp(res, 'return[0]/status', 'concluded')
216
+
# Leave zombie job un-dismissed, observe a failure:
217
+
res = self.qmp_backup_and_wait(serror='Need a root block node',
218
+
device='drive0', format=iotests.imgfmt,
219
+
sync='full', target=self.dest_img,
220
+
auto_dismiss=False)
221
+
self.assertEqual(res, False)
222
+
# OK, dismiss the zombie.
223
+
res = self.vm.qmp('block-job-dismiss', id='drive0')
224
+
self.assert_qmp(res, 'return', {})
225
+
res = self.vm.qmp('query-block-jobs')
226
+
self.assert_qmp(res, 'return', [])
227
+
# Ensure it's really gone.
228
+
self.qmp_backup_and_wait(device='drive0', format=iotests.imgfmt,
229
+
sync='full', target=self.dest_img,
230
+
auto_dismiss=False)
231
+
232
+
def dismissal_failure(self, dismissal_opt):
233
+
res = self.vm.qmp('query-block-jobs')
234
+
self.assert_qmp(res, 'return', [])
235
+
# Give blkdebug something to chew on
236
+
self.hmp_io_writes('drive0',
237
+
(('0x9a', 0, 512),
238
+
('0x55', '8M', '352k'),
239
+
('0x78', '15872k', '1M')))
240
+
# Add destination node via blkdebug
241
+
res = self.vm.qmp('blockdev-add',
242
+
node_name='target0',
243
+
driver=iotests.imgfmt,
244
+
file={
245
+
'driver': 'blkdebug',
246
+
'image': {
247
+
'driver': 'file',
248
+
'filename': self.dest_img
249
+
},
250
+
'inject-error': [{
251
+
'event': 'write_aio',
252
+
'errno': 5,
253
+
'immediately': False,
254
+
'once': True
255
+
}],
256
+
})
257
+
self.assert_qmp(res, 'return', {})
258
+
259
+
res = self.qmp_backup(cmd='blockdev-backup',
260
+
device='drive0', target='target0',
261
+
on_target_error='stop',
262
+
sync='full',
263
+
auto_dismiss=dismissal_opt)
264
+
self.assertTrue(res)
265
+
event = self.vm.event_wait(name="BLOCK_JOB_ERROR",
266
+
match={'data': {'device': 'drive0'}})
267
+
self.assertNotEqual(event, None)
268
+
# OK, job should be wedged
269
+
res = self.vm.qmp('query-block-jobs')
270
+
self.assert_qmp(res, 'return[0]/status', 'paused')
271
+
res = self.vm.qmp('block-job-dismiss', id='drive0')
272
+
self.assert_qmp(res, 'error/desc',
273
+
"Job 'drive0' in state 'paused' cannot accept"
274
+
" command verb 'dismiss'")
275
+
res = self.vm.qmp('query-block-jobs')
276
+
self.assert_qmp(res, 'return[0]/status', 'paused')
277
+
# OK, unstick job and move forward.
278
+
res = self.vm.qmp('block-job-resume', device='drive0')
279
+
self.assert_qmp(res, 'return', {})
280
+
# And now we need to wait for it to conclude;
281
+
res = self.qmp_backup_wait(device='drive0')
282
+
self.assertTrue(res)
283
+
if not dismissal_opt:
284
+
# Job should now be languishing:
285
+
res = self.vm.qmp('query-block-jobs')
286
+
self.assert_qmp(res, 'return[0]/status', 'concluded')
287
+
res = self.vm.qmp('block-job-dismiss', id='drive0')
288
+
self.assert_qmp(res, 'return', {})
289
+
res = self.vm.qmp('query-block-jobs')
290
+
self.assert_qmp(res, 'return', [])
291
+
292
+
def test_dismiss_premature(self):
293
+
self.dismissal_failure(False)
294
+
295
+
def test_dismiss_erroneous(self):
296
+
self.dismissal_failure(True)
110
297
111
298
if __name__ == '__main__':
112
299
iotests.main(supported_fmts=['qcow2', 'qed'])