jcs.org
qemu with hax to log dma reads & writes
jcs.org/2018/11/12/vfio
usb/dev-mtp: Fix Error double free after inotify failure
error_report_err() frees its first argument. Freeing it again is
wrong. Don't.
Fixes: 47287c27d0c367a89f7b2851e23a7f8b2d499dd6
Cc: Gerd Hoffmann <kraxel@redhat.com>
Cc: Daniel P. Berrangé <berrange@redhat.com>
Cc: qemu-stable@nongnu.org
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Message-Id: <20200630090351.1247703-7-armbru@redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
-2
-2
hw/usb/dev-mtp.c
-2
hw/usb/dev-mtp.c
···
634
634
error_reportf_err(err,
635
635
"usb-mtp: failed to add watch for %s: ",
636
636
o->path);
637
-
error_free(err);
638
637
} else {
639
638
trace_usb_mtp_file_monitor_event(s->dev.addr, o->path,
640
639
"Watch Added");
···
1279
1278
if (err) {
1280
1279
error_reportf_err(err,
1281
1280
"usb-mtp: file monitoring init failed: ");
1282
-
error_free(err);
1283
1281
} else {
1284
1282
QTAILQ_INIT(&s->events);
1285
1283
}