jcs.org / qemu
qemu with hax to log dma reads & writes jcs.org/2018/11/12/vfio
fork atom

migration: forbid bitmap migration by generated node-name

It actually never worked with libvirt, as auto-generated names are
different on source and destination.

It's unsafe and useless to migrate by auto-generated node-names, so
let's forbid it.

Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Reviewed-by: Andrey Shinkevich <andrey.shinkevich@virtuozzo.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Message-Id: <20200521220648.3255-7-vsementsov@virtuozzo.com>
[eblake: shorter subject line]
Signed-off-by: Eric Blake <eblake@redhat.com>

authored by

Vladimir Sementsov-Ogievskiy and committed by
Eric Blake 4ff5cc12 82640edb

+7
+7
migration/block-dirty-bitmap.c
··· 285 285 return -1; 286 286 } 287 287 288 + if (bs_name[0] == '#') { 289 + error_report("Bitmap '%s' in a node with auto-generated " 290 + "name '%s' can't be migrated", 291 + bdrv_dirty_bitmap_name(bitmap), bs_name); 292 + return -1; 293 + } 294 + 288 295 FOR_EACH_DIRTY_BITMAP(bs, bitmap) { 289 296 if (!bdrv_dirty_bitmap_name(bitmap)) { 290 297 continue;