jcs.org / qemu
qemu with hax to log dma reads & writes jcs.org/2018/11/12/vfio
fork atom

tests: Move tests/hex-loader-check-data/ to tests/data/hex-loader/

Currently tests/hex-loader-check-data contains data files used
by the hexloader-test, and configure individually symlinks those
data files into the build directory using a wildcard.

Using a wildcard like this is a bad idea, because if a new
data file is added, nothing causes configure to be rerun,
and so no symlink is added for the new file. This can cause
tests to spuriously fail when they can't find their data.
Instead, it's better to symlink an entire directory of
data files. We already have such a directory: tests/data.

Move the data files from tests/hex-loader-check-data/ to
tests/data/hex-loader/, and remove the unnecessary symlinking.

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>

authored by

Peter Maydell and committed by
Michael S. Tsirkin 4b2ff65a 438c78da

+2 -6
+1 -1
MAINTAINERS
··· 1370 1370 M: Su Hang <suhang16@mails.ucas.ac.cn> 1371 1371 S: Maintained 1372 1372 F: tests/hexloader-test.c 1373 - F: tests/hex-loader-check-data/test.hex 1373 + F: tests/data/hex-loader/test.hex 1374 1374 1375 1375 CHRP NVRAM 1376 1376 M: Thomas Huth <thuth@redhat.com>
-4
configure
··· 7421 7421 do 7422 7422 FILES="$FILES pc-bios/$(basename $bios_file)" 7423 7423 done 7424 - for test_file in $(find $source_path/tests/hex-loader-check-data -type f) 7425 - do 7426 - FILES="$FILES tests/hex-loader-check-data$(echo $test_file | sed -e 's/.*hex-loader-check-data//')" 7427 - done 7428 7424 mkdir -p $DIRS 7429 7425 for f in $FILES ; do 7430 7426 if [ -e "$source_path/$f" ] && [ "$pwd_is_source_path" != "y" ]; then
tests/hex-loader-check-data/test.hex tests/data/hex-loader/test.hex
+1 -1
tests/hexloader-test.c
··· 23 23 const unsigned int base_addr = 0x00010000; 24 24 25 25 QTestState *s = qtest_initf( 26 - "-M vexpress-a9 -nographic -device loader,file=tests/hex-loader-check-data/test.hex"); 26 + "-M vexpress-a9 -nographic -device loader,file=tests/data/hex-loader/test.hex"); 27 27 28 28 for (i = 0; i < 256; ++i) { 29 29 uint8_t val = qtest_readb(s, base_addr + i);