qemu with hax to log dma reads & writes jcs.org/2018/11/12/vfio

readline: don't free completions in readline_free()

Since commit e5dc1a6c6c43, QEMU aborts on exit if completion was used
in the monitor:

*** Error in `obj/ppc64-softmmu/qemu-system-ppc64': double free or
corruption (fasttop): 0x00000100331069d0 ***

/home/greg/Work/qemu/qemu-spapr/util/readline.c:514
/home/greg/Work/qemu/qemu-spapr/monitor.c:586
/home/greg/Work/qemu/qemu-spapr/monitor.c:4125
argv=<optimized out>, envp=<optimized out>) at
/home/greg/Work/qemu/qemu-spapr/vl.c:4795

Completion strings are not persistent accross completions (why would
they?). They are allocated under readline_completion(), which already
takes care of freeing them before returning.

Maybe all completion related bits should be moved out of ReadLineState
to a dedicated structure ?

In the meantime, let's drop the offending lines from readline_free()
to fix the crash.

Signed-off-by: Greg Kurz <groug@kaod.org>
Message-Id: <151627206353.4505.4602428849861610759.stgit@bahia.lan>
Fixes: e5dc1a6c6c43
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>

authored by

Greg Kurz and committed by
Paolo Bonzini
4183e2ea 4e4b5734

-3
-3
util/readline.c
··· 510 510 for (i = 0; i < READLINE_MAX_CMDS; i++) { 511 511 g_free(rs->history[i]); 512 512 } 513 - for (i = 0; i < READLINE_MAX_COMPLETIONS; i++) { 514 - g_free(rs->completions[i]); 515 - } 516 513 g_free(rs); 517 514 } 518 515