migration/colo: fix use after free of local_err

qemu with hax to log dma reads & writes jcs.org/2018/11/12/vfio

local_err is used again in secondary_vm_do_failover() after
replication_stop_all(), so we must zero it. Otherwise try to set
non-NULL local_err will crash.

Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Message-Id: <20200324153630.11882-5-vsementsov@virtuozzo.com>
Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>

authored by

Vladimir Sementsov-Ogievskiy and committed by

Dr. David Alan Gilbert 6 years ago 27d07fcf d96c4d5f

1 changed file

expand all

migration

colo.c

migration/colo.c

··· 93 93 replication_stop_all(true, &local_err); 94 94 if (local_err) { 95 95 error_report_err(local_err); 96 + local_err = NULL; 96 97 } 97 98 98 99 /* Notify all filters of all NIC to do checkpoint */