jcs.org / qemu
qemu with hax to log dma reads & writes jcs.org/2018/11/12/vfio
fork atom

tests/qapi-schema: Improve doc / expression mismatch coverage

New tests doc-before-include.json and doc-before-pragma.json show we
fail to reject a misplaced expression comment.

New test doc-no-symbol.json shows a bad error message.

Signed-off-by: Markus Armbruster <armbru@redhat.com>
Message-Id: <1489582656-31133-31-git-send-email-armbru@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>

Markus Armbruster 2028be8e 75b50196

+38
+3
tests/Makefile.include
··· 369 369 qapi-schema += comments.json 370 370 qapi-schema += doc-bad-args.json 371 371 qapi-schema += doc-bad-symbol.json 372 + qapi-schema += doc-before-include.json 373 + qapi-schema += doc-before-pragma.json 372 374 qapi-schema += doc-duplicated-arg.json 373 375 qapi-schema += doc-duplicated-return.json 374 376 qapi-schema += doc-duplicated-since.json ··· 385 387 qapi-schema += doc-missing-colon.json 386 388 qapi-schema += doc-missing-expr.json 387 389 qapi-schema += doc-missing-space.json 390 + qapi-schema += doc-no-symbol.json 388 391 qapi-schema += double-data.json 389 392 qapi-schema += double-type.json 390 393 qapi-schema += duplicate-key.json
tests/qapi-schema/doc-before-include.err

This is a binary file and will not be displayed.

+1
tests/qapi-schema/doc-before-include.exit
··· 1 + 0
+8
tests/qapi-schema/doc-before-include.json
··· 1 + # Doc comment separated from defining expression by non-defining expression 2 + # BUG: not rejected 3 + 4 + ## 5 + # @foo: 6 + ## 7 + { 'include': 'empty.json' } 8 + { 'struct': 'foo', 'data': {} }
+4
tests/qapi-schema/doc-before-include.out
··· 1 + enum QType ['none', 'qnull', 'qint', 'qstring', 'qdict', 'qlist', 'qfloat', 'qbool'] 2 + prefix QTYPE 3 + object foo 4 + object q_empty
tests/qapi-schema/doc-before-pragma.err

This is a binary file and will not be displayed.

+1
tests/qapi-schema/doc-before-pragma.exit
··· 1 + 0
+8
tests/qapi-schema/doc-before-pragma.json
··· 1 + # Doc comment separated from defining expression by non-defining expression 2 + # BUG: not rejected 3 + 4 + ## 5 + # @foo: 6 + ## 7 + { 'pragma': {} } 8 + { 'struct': 'foo', 'data': {} }
+4
tests/qapi-schema/doc-before-pragma.out
··· 1 + enum QType ['none', 'qnull', 'qint', 'qstring', 'qdict', 'qlist', 'qfloat', 'qbool'] 2 + prefix QTYPE 3 + object foo 4 + object q_empty
+1
tests/qapi-schema/doc-no-symbol.err
··· 1 + tests/qapi-schema/doc-no-symbol.json:4: Definition of 'foo' follows documentation for 'None'
+1
tests/qapi-schema/doc-no-symbol.exit
··· 1 + 1
+7
tests/qapi-schema/doc-no-symbol.json
··· 1 + # Documentation for expression lacks symbol 2 + # BUG: Error message claims it has symbol 'None' 3 + 4 + ## 5 + # foo: 6 + ## 7 + { 'command': 'foo', 'data': {'a': 'int'} }
tests/qapi-schema/doc-no-symbol.out

This is a binary file and will not be displayed.