···1619 histogram!("storage_trim_dirty_nsids").record(completed.len() as f64);
1620 histogram!("storage_trim_duration").record(dt.as_micros() as f64);
1621 counter!("storage_trim_removed", "dangling" => "true").increment(total_danglers as u64);
1622- counter!("storage_trim_removed", "dangling" => "false").increment((total_deleted - total_danglers) as u64);
000001623 for c in completed {
1624 dirty_nsids.remove(&c);
1625 }
···1619 histogram!("storage_trim_dirty_nsids").record(completed.len() as f64);
1620 histogram!("storage_trim_duration").record(dt.as_micros() as f64);
1621 counter!("storage_trim_removed", "dangling" => "true").increment(total_danglers as u64);
1622+ if total_deleted >= total_danglers {
1623+ counter!("storage_trim_removed", "dangling" => "false").increment((total_deleted - total_danglers) as u64);
1624+ } else {
1625+ // TODO: probably think through what's happening here
1626+ log::warn!("weird trim case: more danglers than deleted? metric will be missing for dangling=false. deleted={total_deleted} danglers={total_danglers}");
1627+ }
1628 for c in completed {
1629 dirty_nsids.remove(&c);
1630 }