Your one-stop-cake-shop for everything Freshly Baked has to offer

fix(m): correct copy behavior #168

merged opened by a.starrysky.fyi targeting main from private/minion/push-zrsmnqrzxvrp

During development, I:

  • used go/ rather than a host for the copied URL
  • used navigator.clipboard, which can't be used outside of secure contexts, and didn't clean up when I changed that
Labels

None yet.

requested-reviewers

None yet.

approved

None yet.

tested-working

None yet.

rejected

None yet.

assignee

None yet.

Participants 1
AT URI
at://did:plc:uuyqs6y3pwtbteet4swt5i5y/sh.tangled.repo.pull/3mc63fmfetb22
+1 -1
Diff #0
+1 -1
menu/src/html/create/success.html
··· 17 <p>Your new shortlink is up!</p> 18 <p><a href="/{from:url}">{host}/{from}</a> now goes to <a href="{to:attribute}">{to}</a></p> 19 <ul> 20 - <li>Access it at <a href="/{from:url}">{host}/{from}</a> (<span id="copy" text="go/{from:attribute}" onclick="navigator.clipboard.writeText(this.getAttribute('text')); ">copy</span>)</li> 21 <li><a href="/_/create">Create another one</a></li> 22 <li><a href="/_/create?from={from:url}&to={to:url}&current={to:url}">Edit it</a></li> 23 <li><a href="/_/delete/do?from={from:url}&current={to:url}">Delete it</a></li>
··· 17 <p>Your new shortlink is up!</p> 18 <p><a href="/{from:url}">{host}/{from}</a> now goes to <a href="{to:attribute}">{to}</a></p> 19 <ul> 20 + <li>Access it at <a href="/{from:url}">{host}/{from}</a> (<span id="copy" text="{host:attribute}/{from:attribute}">copy</span>)</li> 21 <li><a href="/_/create">Create another one</a></li> 22 <li><a href="/_/create?from={from:url}&to={to:url}&current={to:url}">Edit it</a></li> 23 <li><a href="/_/delete/do?from={from:url}&current={to:url}">Delete it</a></li>

History

1 round 0 comments
sign up or login to add to the discussion
a.starrysky.fyi submitted #0
1 commit
expand
fix(m): correct copy behavior
5/5 success
expand
expand 0 comments
pull request successfully merged