fix(pm): don't fail evaluation on multiple homes #156

merged opened by

a.starrysky.fyi 2 months ago targeting main from private/minion/push-klmklpzwxtxu

As a regression from some of the assertion refactoring...

When you have multiple homes, we were previously comparing the entire config of each of them to all of the rest. This was a Bad Thing as it caused us to evaluate the whole of each home, including some attributes that normally aren't evaluated and broke evaluation completely.

This was relevant for Maya but not for the rest of us - I'm not sure how CI missed it...

STACK 1

#156 fix(pm): don't fail evaluation on multiple homes

5/5

0 comments

round #1

Labels

None yet.

requested-reviewers

None yet.

approved

None yet.

tested-working

None yet.

rejected

None yet.

assignee

None yet.

Participants 1

AT URI

at://did:plc:uuyqs6y3pwtbteet4swt5i5y/sh.tangled.repo.pull/3mbocugqsxc22

+3 -1

1 changed file

Diff round #1

expand all

unified split

packetmix

modules

nilla-home

nixos.nix

+3 -1

packetmix/modules/nilla-home/nixos.nix

··· 67 67 ( 68 68 values: 69 69 let 70 - existingUsernames = builtins.filter (value: value.username != null) values; 70 + existingUsernames = map (value: value.username) ( 71 + builtins.filter (value: value.username != null) values 72 + ); 71 73 uniqueUsernames = lib.lists.unique existingUsernames; 72 74 in 73 75 if existingUsernames != uniqueUsernames then