freshlybakedca.ke / patisserie
Your one-stop-cake-shop for everything Freshly Baked has to offer
fork atom

ci: fetch dependencies before evaluate #128

merged opened by a.starrysky.fyi targeting main from private/minion/push-mlmuvqqtptlt

Due to what I suspect must be either an npins or a lix bug, we get this error when evaluating our configuration on new machines:

… while fetching the input 'git+https://gerrit.wikimedia.org/r/mediawiki/extensions/AdvancedSearch?rev=398c9fa782843d8b3aeaa5ebb1c1b3db35c3382f'

error: Cannot find Git revision '398c9fa782843d8b3aeaa5ebb1c1b3db35c3382f' in ref 'refs/heads/master' of repository 'https://gerrit.wikimedia.org/r/mediawiki/extensions/AdvancedSearch'! Please make sure that the rev exists on the ref you've specified or add allRefs = true; to fetchGit.

Now, this is what I'd expect - because we're not meant to be fetching master of this extension - we're meant to be fetching a branch! By using npins to prefetch all dependencies, we get around this.

Due to a nilla bug, fetching dependencies is required for evaluation anyway - so this isn't too much more of an issue than it would already have been...

STACK 4
#130 chore(pm): replace pkgs.system uses
0
#8
#127 feat(pm/wiki): allow category membership tracking
0
#14
#128 ci: fetch dependencies before evaluate
0
#14
#129 chore: remove defunct license
0
#14
ABANDONED PULLS 1
#131 chore: bump nillas to testing versions
0
#6
Labels

None yet.

requested-reviewers

None yet.

approved

None yet.

tested-working

None yet.

rejected

None yet.

assignee

None yet.

Participants 1
AT URI
at://did:plc:uuyqs6y3pwtbteet4swt5i5y/sh.tangled.repo.pull/3mbbxryg4sg22
+30 -14
Interdiff #5 → #6
unified split
+30 -14
packetmix/npins/default.nix
··· 89 89 name, 90 90 narHash, 91 91 }: 92 - pkgs.fetchgit ({ 93 - inherit url rev name; 94 - fetchSubmodules = submodules; 95 - hash = narHash; 96 - } // (if branch == null then {} else { 97 - ref = "refs/heads/${branch}"; 98 - })); 92 + pkgs.fetchgit ( 93 + { 94 + inherit url rev name; 95 + fetchSubmodules = submodules; 96 + hash = narHash; 97 + } 98 + // ( 99 + if branch == null then 100 + { } 101 + else 102 + { 103 + ref = "refs/heads/${branch}"; 104 + } 105 + ) 106 + ); 99 107 }; 100 108 101 109 # Dispatch to the correct code path based on the type ··· 163 171 "${if matched == null then "source" else builtins.head matched}${appendShort}"; 164 172 name = urlToName url revision; 165 173 in 166 - fetchGit ({ 167 - rev = revision; 168 - narHash = hash; 174 + fetchGit ( 175 + { 176 + rev = revision; 177 + narHash = hash; 169 178 170 - inherit name submodules url; 171 - } // (if branch == null then {} else { 172 - ref = "refs/heads/${branch}"; 173 - })); 179 + inherit name submodules url; 180 + } 181 + // ( 182 + if branch == null then 183 + { } 184 + else 185 + { 186 + ref = "refs/heads/${branch}"; 187 + } 188 + ) 189 + ); 174 190 175 191 mkPyPiSource = 176 192 { fetchurl, ... }:
packetmix/npins/sources.json

This file has not been changed.

History

15 rounds 0 comments
sign up or login to add to the discussion
a.starrysky.fyi submitted #14
diff interdiff
1 commit
expand
8f2a08cc
fix(npins): fetch dependencies from correct ref
expand 0 comments
pull request successfully merged
a.starrysky.fyi submitted #13
diff interdiff
1 commit
expand
8f2a08cc
fix(npins): fetch dependencies from correct ref
expand 0 comments
a.starrysky.fyi submitted #12
diff interdiff
1 commit
expand
8f2a08cc
fix(npins): fetch dependencies from correct ref
expand 0 comments
a.starrysky.fyi submitted #11
diff interdiff
1 commit
expand
8f2a08cc
fix(npins): fetch dependencies from correct ref
expand 0 comments
a.starrysky.fyi submitted #10
diff interdiff
1 commit
expand
8f2a08cc
fix(npins): fetch dependencies from correct ref
expand 0 comments
a.starrysky.fyi submitted #9
diff interdiff
1 commit
expand
8f2a08cc
fix(npins): fetch dependencies from correct ref
expand 0 comments
a.starrysky.fyi submitted #8
diff interdiff
1 commit
expand
8f2a08cc
fix(npins): fetch dependencies from correct ref
expand 0 comments
a.starrysky.fyi submitted #7
diff interdiff
1 commit
expand
8f2a08cc
fix(npins): fetch dependencies from correct ref
expand 0 comments
a.starrysky.fyi submitted #6
diff
1 commit
expand
8f2a08cc
fix(npins): fetch dependencies from correct ref
expand 0 comments
a.starrysky.fyi submitted #5
diff interdiff
1 commit
expand
6e742493
fix(npins): fetch dependencies from correct ref
expand 0 comments
a.starrysky.fyi submitted #4
diff interdiff
1 commit
expand
f4458881
fix(npins): fetch dependencies from correct ref
expand 0 comments
a.starrysky.fyi submitted #3
diff interdiff
1 commit
expand
dbb29bda
fix(npins): fetch dependencies from correct ref
expand 0 comments
a.starrysky.fyi submitted #2
diff interdiff
1 commit
expand
f8c3bf45
fix(npins): fetch dependencies from correct ref
expand 0 comments
a.starrysky.fyi submitted #1
diff interdiff
1 commit
expand
9983a932
ci: fetch dependencies before evaluate
expand 0 comments
a.starrysky.fyi submitted #0
diff
1 commit
expand
d3a5fd61
ci: fetch dependencies before evaluate
expand 0 comments