Git fork

Merge branch 'jc/3.0-default-initial-branch-to-main-addendum'

Keep giving hint about the default initial branch name for users
who may be surprised after Git 3.0 switch-over.

* jc/3.0-default-initial-branch-to-main-addendum:
initial branch: give hints after switching the default name

+19 -11
-2
advice.c
··· 51 [ADVICE_AM_WORK_DIR] = { "amWorkDir" }, 52 [ADVICE_CHECKOUT_AMBIGUOUS_REMOTE_BRANCH_NAME] = { "checkoutAmbiguousRemoteBranchName" }, 53 [ADVICE_COMMIT_BEFORE_MERGE] = { "commitBeforeMerge" }, 54 - #ifndef WITH_BREAKING_CHANGES 55 [ADVICE_DEFAULT_BRANCH_NAME] = { "defaultBranchName" }, 56 - #endif /* WITH_BREAKING_CHANGES */ 57 [ADVICE_DETACHED_HEAD] = { "detachedHead" }, 58 [ADVICE_DIVERGING] = { "diverging" }, 59 [ADVICE_FETCH_SET_HEAD_WARN] = { "fetchRemoteHEADWarn" },
··· 51 [ADVICE_AM_WORK_DIR] = { "amWorkDir" }, 52 [ADVICE_CHECKOUT_AMBIGUOUS_REMOTE_BRANCH_NAME] = { "checkoutAmbiguousRemoteBranchName" }, 53 [ADVICE_COMMIT_BEFORE_MERGE] = { "commitBeforeMerge" }, 54 [ADVICE_DEFAULT_BRANCH_NAME] = { "defaultBranchName" }, 55 [ADVICE_DETACHED_HEAD] = { "detachedHead" }, 56 [ADVICE_DIVERGING] = { "diverging" }, 57 [ADVICE_FETCH_SET_HEAD_WARN] = { "fetchRemoteHEADWarn" },
+1 -3
advice.h
··· 18 ADVICE_AM_WORK_DIR, 19 ADVICE_CHECKOUT_AMBIGUOUS_REMOTE_BRANCH_NAME, 20 ADVICE_COMMIT_BEFORE_MERGE, 21 - #ifndef WITH_BREAKING_CHANGES 22 - ADVICE_DEFAULT_BRANCH_NAME, 23 - #endif /* WITH_BREAKING_CHANGES */ 24 ADVICE_DETACHED_HEAD, 25 ADVICE_DIVERGING, 26 ADVICE_FETCH_SET_HEAD_WARN,
··· 18 ADVICE_AM_WORK_DIR, 19 ADVICE_CHECKOUT_AMBIGUOUS_REMOTE_BRANCH_NAME, 20 ADVICE_COMMIT_BEFORE_MERGE, 21 + ADVICE_DEFAULT_BRANCH_NAME, /* To be retired sometime after Git 3.0 */ 22 ADVICE_DETACHED_HEAD, 23 ADVICE_DIVERGING, 24 ADVICE_FETCH_SET_HEAD_WARN,
+10 -2
refs.c
··· 641 "\n" 642 "\tgit branch -m <name>\n" 643 ); 644 #endif /* WITH_BREAKING_CHANGES */ 645 646 - char *repo_default_branch_name(struct repository *r, MAYBE_UNUSED int quiet) 647 { 648 const char *config_key = "init.defaultbranch"; 649 const char *config_display_key = "init.defaultBranch"; ··· 660 ret = xstrdup("main"); 661 #else 662 ret = xstrdup("master"); 663 if (!quiet) 664 advise_if_enabled(ADVICE_DEFAULT_BRANCH_NAME, 665 _(default_branch_name_advice), ret); 666 - #endif /* WITH_BREAKING_CHANGES */ 667 } 668 669 full_ref = xstrfmt("refs/heads/%s", ret);
··· 641 "\n" 642 "\tgit branch -m <name>\n" 643 ); 644 + #else 645 + static const char default_branch_name_advice[] = N_( 646 + "Using '%s' as the name for the initial branch since Git 3.0.\n" 647 + "If you expected Git to create 'master', the just-created\n" 648 + "branch can be renamed via this command:\n" 649 + "\n" 650 + "\tgit branch -m master\n" 651 + ); 652 #endif /* WITH_BREAKING_CHANGES */ 653 654 + char *repo_default_branch_name(struct repository *r, int quiet) 655 { 656 const char *config_key = "init.defaultbranch"; 657 const char *config_display_key = "init.defaultBranch"; ··· 668 ret = xstrdup("main"); 669 #else 670 ret = xstrdup("master"); 671 + #endif /* WITH_BREAKING_CHANGES */ 672 if (!quiet) 673 advise_if_enabled(ADVICE_DEFAULT_BRANCH_NAME, 674 _(default_branch_name_advice), ret); 675 } 676 677 full_ref = xstrfmt("refs/heads/%s", ret);
+1 -1
t/t0001-init.sh
··· 868 grep nmb actual 869 ' 870 871 - test_expect_success !WITH_BREAKING_CHANGES 'advice on unconfigured init.defaultBranch' ' 872 GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME= git -c color.advice=always \ 873 init unconfigured-default-branch-name 2>err && 874 test_decode_color <err >decoded &&
··· 868 grep nmb actual 869 ' 870 871 + test_expect_success 'advice on unconfigured init.defaultBranch' ' 872 GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME= git -c color.advice=always \ 873 init unconfigured-default-branch-name 2>err && 874 test_decode_color <err >decoded &&
+7 -3
t/test-lib.sh
··· 127 export GIT_TEST_DISALLOW_ABBREVIATED_OPTIONS 128 fi 129 130 if test -z "$WITH_BREAKING_CHANGES" 131 then 132 - # Explicitly set the default branch name for testing, to avoid the 133 - # transitory "git init" warning under --verbose. 134 : ${GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME:=master} 135 - export GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME 136 fi 137 138 ################################################################ 139 # It appears that people try to run tests without building...
··· 127 export GIT_TEST_DISALLOW_ABBREVIATED_OPTIONS 128 fi 129 130 + # Explicitly set the default branch name for testing, to squelch hints 131 + # from "git init" during the transition period. Should be removed 132 + # after we decide to remove ADVICE_DEFAULT_BRANCH_NAME 133 if test -z "$WITH_BREAKING_CHANGES" 134 then 135 : ${GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME:=master} 136 + else 137 + : ${GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME:=main} 138 fi 139 + export GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME 140 + 141 142 ################################################################ 143 # It appears that people try to run tests without building...