freshlybakedca.ke
Git fork
Merge branch 'js/curl-off-t-fixes'
A few places where an size_t value was cast to curl_off_t without
checking has been updated to use the existing helper function.
* js/curl-off-t-fixes:
http-push: avoid new compile error
imap-send: be more careful when casting to `curl_off_t`
http: offer to cast `size_t` to `curl_off_t` safely
+2
-1
http-push.c
+2
-1
http-push.c
···
208
208
curl_easy_setopt(curl, CURLOPT_UPLOAD, 1L);
209
209
curl_easy_setopt(curl, CURLOPT_URL, url);
210
210
curl_easy_setopt(curl, CURLOPT_INFILE, buffer);
211
-
curl_easy_setopt(curl, CURLOPT_INFILESIZE, buffer->buf.len);
211
+
curl_easy_setopt(curl, CURLOPT_INFILESIZE_LARGE,
212
+
cast_size_t_to_curl_off_t(buffer->buf.len));
212
213
curl_easy_setopt(curl, CURLOPT_READFUNCTION, fread_buffer);
213
214
curl_easy_setopt(curl, CURLOPT_SEEKFUNCTION, seek_buffer);
214
215
curl_easy_setopt(curl, CURLOPT_SEEKDATA, buffer);
+10
http.h
+10
http.h
···
8
8
#include <curl/curl.h>
9
9
#include <curl/easy.h>
10
10
11
+
#include "gettext.h"
11
12
#include "strbuf.h"
12
13
#include "remote.h"
13
14
···
94
95
}
95
96
96
97
#define missing_target(a) missing__target((a)->http_code, (a)->curl_result)
98
+
99
+
static inline curl_off_t cast_size_t_to_curl_off_t(size_t a)
100
+
{
101
+
uintmax_t size = a;
102
+
if (size > maximum_signed_value_of_type(curl_off_t))
103
+
die(_("number too large to represent as curl_off_t "
104
+
"on this platform: %"PRIuMAX), (uintmax_t)a);
105
+
return (curl_off_t)a;
106
+
}
97
107
98
108
/*
99
109
* Normalize curl results to handle CURL_FAILONERROR (or lack thereof). Failing
+1
-1
imap-send.c
+1
-1
imap-send.c
+3
-11
remote-curl.c
+3
-11
remote-curl.c
···
894
894
return err;
895
895
}
896
896
897
-
static curl_off_t xcurl_off_t(size_t len)
898
-
{
899
-
uintmax_t size = len;
900
-
if (size > maximum_signed_value_of_type(curl_off_t))
901
-
die(_("cannot handle pushes this big"));
902
-
return (curl_off_t)size;
903
-
}
904
-
905
897
/*
906
898
* If flush_received is true, do not attempt to read any more; just use what's
907
899
* in rpc->buf.
···
999
991
* and we just need to send it.
1000
992
*/
1001
993
curl_easy_setopt(slot->curl, CURLOPT_POSTFIELDS, gzip_body);
1002
-
curl_easy_setopt(slot->curl, CURLOPT_POSTFIELDSIZE_LARGE, xcurl_off_t(gzip_size));
994
+
curl_easy_setopt(slot->curl, CURLOPT_POSTFIELDSIZE_LARGE, cast_size_t_to_curl_off_t(gzip_size));
1003
995
1004
996
} else if (use_gzip && 1024 < rpc->len) {
1005
997
/* The client backend isn't giving us compressed data so
···
1030
1022
1031
1023
headers = curl_slist_append(headers, "Content-Encoding: gzip");
1032
1024
curl_easy_setopt(slot->curl, CURLOPT_POSTFIELDS, gzip_body);
1033
-
curl_easy_setopt(slot->curl, CURLOPT_POSTFIELDSIZE_LARGE, xcurl_off_t(gzip_size));
1025
+
curl_easy_setopt(slot->curl, CURLOPT_POSTFIELDSIZE_LARGE, cast_size_t_to_curl_off_t(gzip_size));
1034
1026
1035
1027
if (options.verbosity > 1) {
1036
1028
fprintf(stderr, "POST %s (gzip %lu to %lu bytes)\n",
···
1043
1035
* more normal Content-Length approach.
1044
1036
*/
1045
1037
curl_easy_setopt(slot->curl, CURLOPT_POSTFIELDS, rpc->buf);
1046
-
curl_easy_setopt(slot->curl, CURLOPT_POSTFIELDSIZE_LARGE, xcurl_off_t(rpc->len));
1038
+
curl_easy_setopt(slot->curl, CURLOPT_POSTFIELDSIZE_LARGE, cast_size_t_to_curl_off_t(rpc->len));
1047
1039
if (options.verbosity > 1) {
1048
1040
fprintf(stderr, "POST %s (%lu bytes)\n",
1049
1041
rpc->service_name, (unsigned long)rpc->len);