Merge branch 'js/unreachable-workaround-for-no-symlink-head'

freshlybakedca.ke / git

fork atom

Git fork

fork atom

Code clean-up.

* js/unreachable-workaround-for-no-symlink-head:
refs: forbid clang to complain about unreachable code

Junio C Hamano 4 months ago 5a34f66f fc00bf0f

+7 -1

1 changed file

expand all

unified split

refs

files-backend.c

+7 -1

refs/files-backend.c

··· 3327 * next update. If not, we try and create a regular symref. 3328 */ 3329 if (update->new_target && refs->prefer_symlink_refs) 3330 - if (!create_ref_symlink(lock, update->new_target)) 3331 continue; 3332 3333 if (update->flags & REF_NEEDS_COMMIT) {

··· 3327 * next update. If not, we try and create a regular symref. 3328 */ 3329 if (update->new_target && refs->prefer_symlink_refs) 3330 + /* 3331 + * By using the `NOT_CONSTANT()` trick, we can avoid 3332 + * errors by `clang`'s `-Wunreachable` logic that would 3333 + * report that the `continue` statement is not reachable 3334 + * when `NO_SYMLINK_HEAD` is `#define`d. 3335 + */ 3336 + if (NOT_CONSTANT(!create_ref_symlink(lock, update->new_target))) 3337 continue; 3338 3339 if (update->flags & REF_NEEDS_COMMIT) {