rebase: avoid using the comma operator unnecessarily

Git fork

The comma operator is a somewhat obscure C feature that is often used by
mistake and can even cause unintentional code flow. Better use a
semicolon instead.

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Acked-by: Phillip Wood <phillip.wood@dunelm.org.uk>
Signed-off-by: Junio C Hamano <gitster@pobox.com>

authored by

Johannes Schindelin and committed by

Junio C Hamano 11 months ago 38c696d6 f569065f

+1 -1

1 changed file

expand all

unified split

builtin

rebase.c

+1 -1

builtin/rebase.c

··· 1843 1843 strbuf_addf(&msg, "%s (start): checkout %s", 1844 1844 options.reflog_action, options.onto_name); 1845 1845 ropts.oid = &options.onto->object.oid; 1846 - ropts.orig_head = &options.orig_head->object.oid, 1846 + ropts.orig_head = &options.orig_head->object.oid; 1847 1847 ropts.flags = RESET_HEAD_DETACH | RESET_ORIG_HEAD | 1848 1848 RESET_HEAD_RUN_POST_CHECKOUT_HOOK; 1849 1849 ropts.head_msg = msg.buf;