Git fork

xdiff: avoid using the comma operator unnecessarily

The comma operator is a somewhat obscure C feature that is often used by
mistake and can even cause unintentional code flow. While the code in
this patch used the comma operator intentionally (to avoid curly
brackets around two statements, each, that want to be guarded by a
condition), it is better to surround it with curly brackets and to use a
semicolon instead.

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Acked-by: Phillip Wood <phillip.wood@dunelm.org.uk>
Signed-off-by: Junio C Hamano <gitster@pobox.com>

authored by

Johannes Schindelin and committed by
Junio C Hamano
324fbaab 0fbbb2c9

+8 -4
+8 -4
xdiff/xdiffi.c
··· 211 for (d = fmax; d >= fmin; d -= 2) { 212 i1 = XDL_MIN(kvdf[d], lim1); 213 i2 = i1 - d; 214 - if (lim2 < i2) 215 - i1 = lim2 + d, i2 = lim2; 216 if (fbest < i1 + i2) { 217 fbest = i1 + i2; 218 fbest1 = i1; ··· 223 for (d = bmax; d >= bmin; d -= 2) { 224 i1 = XDL_MAX(off1, kvdb[d]); 225 i2 = i1 - d; 226 - if (i2 < off2) 227 - i1 = off2 + d, i2 = off2; 228 if (i1 + i2 < bbest) { 229 bbest = i1 + i2; 230 bbest1 = i1;
··· 211 for (d = fmax; d >= fmin; d -= 2) { 212 i1 = XDL_MIN(kvdf[d], lim1); 213 i2 = i1 - d; 214 + if (lim2 < i2) { 215 + i1 = lim2 + d; 216 + i2 = lim2; 217 + } 218 if (fbest < i1 + i2) { 219 fbest = i1 + i2; 220 fbest1 = i1; ··· 225 for (d = bmax; d >= bmin; d -= 2) { 226 i1 = XDL_MAX(off1, kvdb[d]); 227 i2 = i1 - d; 228 + if (i2 < off2) { 229 + i1 = off2 + d; 230 + i2 = off2; 231 + } 232 if (i1 + i2 < bbest) { 233 bbest = i1 + i2; 234 bbest1 = i1;