bad-example.com
APIs for links and references in the ATmosphere
put $type in array path
nothing is escaped, unclear how universal the $type convention is, etc.
+8
-5
link_aggregator/readme.md
+8
-5
link_aggregator/readme.md
···
90
90
- [x] jetstream: don't rotate servers, explicitly pass via cli
91
91
- [x] metrics!
92
92
- [x] event ts lag
93
-
- [~] machine resource metrics
93
+
- [x] machine resource metrics
94
94
- [x] disk consumption
95
95
- [x] cpu usage
96
96
- [x] mem usage
97
97
- [x] network?
98
-
- [ ] make all storage apis return Result
98
+
- [ ] make all rocks apis return Result instead of unwrapping
99
99
- [ ] handle all the unwraps
100
100
- [ ] deadletter queue of some kind for failed db writes
101
101
- [ ] also for valid json that was rejected?
···
121
121
- [x] don't remove deleted links from the reverse records -- null them out. this will keep things stable for paging.
122
122
- [x] don't show deactivated accounts in link responses
123
123
- [ ] links:
124
-
- [ ] pull `$type`/`type` from object children of arrays (distinguish replies, quotes, etc)
125
-
- [ ] actually define the format (deal with in-band dots etc)
126
-
- [ ] _could_ throw cid neighbour into the target. probably should? but it's a lot of high volume uncompressible bytes
124
+
- [~] pull `$type`/`type` from object children of arrays (distinguish replies, quotes, etc)
125
+
- just $type to start
126
+
- [ ] rewrite the entire "path" stuff
127
+
- [ ] actually define the format (deal with in-band dots etc)
128
+
- [x] ~_could_ throw cid neighbour into the target. probably should? but it's a lot of high volume uncompressible bytes~
127
129
- and it could be looked up from the linker's doc
130
+
- ^^ for now, look up from source doc to get cid. might revisit this later.
+12
-3
links/src/record.rs
+12
-3
links/src/record.rs
···
10
10
}
11
11
}
12
12
JsonValue::Array(a) => {
13
-
let p = format!("{path}[]");
14
13
for child in a {
15
-
walk_record(&p, child, found)
14
+
let child_p = match child {
15
+
JsonValue::Object(o) => {
16
+
if let Some(JsonValue::String(t)) = o.get("$type") {
17
+
format!("{path}[{t}]")
18
+
} else {
19
+
format!("{path}[]")
20
+
}
21
+
}
22
+
_ => format!("{path}[]"),
23
+
};
24
+
walk_record(&child_p, child, found)
16
25
}
17
26
}
18
27
JsonValue::String(s) => {
···
145
154
Link::Uri("https://youtu.be/oKXm4szEP1Q?si=_0n_uPu4qNKokMnq".into()),
146
155
),
147
156
l(
148
-
".facets[].features[].uri",
157
+
".facets[].features[app.bsky.richtext.facet#link].uri",
149
158
Link::Uri("https://youtu.be/oKXm4szEP1Q?si=_0n_uPu4qNKokMnq".into()),
150
159
),
151
160
]