tangled.org / site
engineering blog at https://blog.tangled.sh
fork atom

Templates/nav: match the style used in core #2

merged opened by jensroemer.com targeting master from jensroemer.com/site: template-nav-match-core-style

This PR changes the nav so that it matches the style used in core. Well, not entirely unfortunately since core uses Inter for the logo text and the blog ends up with SF somehow - I didn't have the time to look into it, but I guess it's supposed to be Inter too. Nav now also uses a semantically correct element as well as a simpler markup structure.

Labels

None yet.

Participants 2
AT URI
at://did:plc:laqygfbyvnkyuhsuaxmp6ez3/sh.tangled.repo.pull/3m7lfz7dl5z22
+5 -9
Diff #0
unified split
+5 -9
templates/partials/nav.html
··· 1 - <div class="w-full"> 2 - <div class="container mx-auto max-w-7xl px-4"> 3 - <div class="flex justify-start py-4 mb-8"> 4 - <a href="/" class="text-2xl no-underline hover:no-underline"> 5 - {{ template "fragments/logotypeSmall" }} 6 - </a> 7 - </div> 8 - </div> 9 - </div> 1 + <nav class="w-full flex items-center dark:text-white drop-shadow-sm bg-white dark:bg-gray-800 px-6 py-2 h-[44px]"> 2 + <a href="/" class="text-2xl no-underline hover:no-underline"> 3 + {{ template "fragments/logotypeSmall" }} 4 + </a> 5 + </nav>

History

1 round 1 comment
sign up or login to add to the discussion
jensroemer.com submitted #0
1 commit
expand
d5f77144
Templates/nav: match the style used in core
expand 1 comment
anirudh.fi

Thanks, this looks good!

pull request successfully merged