tangled.org
This was preventing knot and spindle owners from removing members if the members's handle became invalid
-5
appview/knots/knots.go
-5
appview/knots/knots.go
···
666
666
k.Pages.Notice(w, noticeId, "Failed to remove member, identity resolution failed.")
667
667
return
668
668
}
669
-
if memberId.Handle.IsInvalidHandle() {
670
-
l.Error("failed to resolve member identity to handle")
671
-
k.Pages.Notice(w, noticeId, "Failed to remove member, identity resolution failed.")
672
-
return
673
-
}
674
669
675
670
// remove from enforcer
676
671
err = k.Enforcer.RemoveKnotMember(domain, memberId.DID.String())
-5
appview/spindles/spindles.go
-5
appview/spindles/spindles.go
···
653
653
s.Pages.Notice(w, noticeId, "Failed to remove member, identity resolution failed.")
654
654
return
655
655
}
656
-
if memberId.Handle.IsInvalidHandle() {
657
-
l.Error("failed to resolve member identity to handle")
658
-
s.Pages.Notice(w, noticeId, "Failed to remove member, identity resolution failed.")
659
-
return
660
-
}
661
656
662
657
tx, err := s.Db.Begin()
663
658
if err != nil {
History
2 rounds
2 comments
yemou.pink
submitted
#1
1 commit
expand
collapse
ffe32bbc
appview/knots,spindles: ignore invalid handles when removing members
This was preventing knot and spindle owners from removing members if
the members's handle became invalid
Fixes: https://tangled.org/tangled.org/core/issues/192
Signed-off-by: yemou <dev@mou.pink>
expand 1 comment
pull request successfully merged
yemou.pink
submitted
#0
1 commit
expand
collapse
f0df8870
appview/knots,spindles: ignore invalid handles when removing members
This was preventing knot and spindle owners from removing members if
the members's handle became invalid
Fixes: https://tangled.org/tangled.org/core/issues/192
Signed-off-by: yemou <dev@mou.pink>
lgtm! thanks for the contribution.