tangled.org / core
Monorepo for Tangled tangled.org
fork atom

appview/pages/markup: Use QueryEscape, not PathEscape, for query params #833

merged opened by runxiyu.tngl.sh targeting master
Labels

None yet.

assignee

None yet.

Participants 2
AT URI
at://did:plc:oy6bo3cgc6erpohuxwscacbp/sh.tangled.repo.pull/3m6bcgvrkj222
+1 -1
Diff #0
unified split
+1 -1
appview/pages/markup/markdown.go
··· 249 249 repoName := fmt.Sprintf("%s/%s", rctx.RepoInfo.OwnerDid, rctx.RepoInfo.Name) 250 250 251 251 query := fmt.Sprintf("repo=%s&ref=%s&path=%s&raw=true", 252 - url.PathEscape(repoName), url.PathEscape(rctx.RepoInfo.Ref), actualPath) 252 + url.QueryEscape(repoName), url.QueryEscape(rctx.RepoInfo.Ref), actualPath) 253 253 254 254 parsedURL := &url.URL{ 255 255 Scheme: scheme,

History

1 round 1 comment
sign up or login to add to the discussion
runxiyu.tngl.sh submitted #0
1 commit
expand
b804f5b3
appview/pages/markup: Use QueryEscape, not PathEscape, for query params
expand 1 comment
anirudh.fi

Good catch, thanks!

pull request successfully merged