i am gathering feedback on the new pull-review page design, here are some points already raised by users on discord; but feel free to drop your comments below:
from @lesbian.skin:
- difference between top and bottom sections is jarring
- submissions are not collapsible, so requires scroll to see the current submission
- submission header is clickable but does not do anything
- review panel toggle is not obvious
- cramped on more vertical screens
- scrolls to bottom of the latest round, and not the top of it
resizable panescompleted in https://tangled.org/tangled.org/core/commit/6fdd37625f33d894d21c21c6ee81164450df7fd4overscrolling the submissions panel on mobile causes the body to scrollcompleted in https://tangled.org/tangled.org/core/commit/8fab832af89cb344048a9bb52740044211a5372b
from @nel.pet:
- the entire submission should be clickable to look at the diff (although the header includes other interactive items, so unsure if this will feel right)
If two rounds of a change has no line difference, we can hide or gray-out the "Interdiff" button. It's also helpful to show line and file changed counters next to the "Interdiff" button.