jensroemer.com
forked from
tangled.org/site
engineering blog at https://blog.tangled.sh
write about round-based reviews
oppi.li
+16
-4
+16
-4
pages/blog/pulls.md
+16
-4
pages/blog/pulls.md
···
57
rounds of reviews.</figcaption>
58
</figure>
59
60
-
[!!!write more about how this is good?]
61
62
-
Hitting the 'View Patch' button lets you see the diff for each round.
63
-
Inter-diffing -- what changed *between* two rounds -- is planned!
64
65
-
[!!!close off this section]
66
67
## fine, we'll make a patch ourselves
68
···
57
rounds of reviews.</figcaption>
58
</figure>
59
60
+
Rounds are a far superior to standard branch-based
61
+
approaches:
62
63
+
- Submissions are immutable: how many times have your
64
+
reviews gone out-of-date because the author pushed commits
65
+
_during_ your review?
66
+
- Reviews are attached to submissions: at a glance, it is
67
+
easy to tell which comment applies to which "version" of the
68
+
pull-request
69
+
- The author can choose when to resubmit! They can commit as
70
+
much as they want, but a new round begins when they choose
71
+
to hit "resubmit"
72
+
- It is possible to "interdiff" and observe changes made
73
+
across submissions (this is coming very soon to Tangled!)
74
75
+
This [post](https://mitchellh.com/writing/github-changesets)
76
+
by Mitchell Hashimoto goes into further detail on what can
77
+
be achieved with round-based-review.
78
79
## fine, we'll make a patch ourselves
80